Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.15.7 #1589

Closed
wants to merge 1 commit into from
Closed

Conversation

thaJeztah
Copy link
Contributor

Signed-off-by: Sebastiaan van Stijn github@gone.nl

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Contributor Author

Ah, fun; looks like it won't work with Go 1.15;

server_1_8b2786804982 | {"level":"fatal","msg":"Error starting rethinkdb driver: rethinkdb: x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0","time":"2021-01-26T09:43:58Z"}
rdb-proxy_1_1bee00b8fa44 | warn: Driver connection TLS handshake failed: sslv3 alert bad certificate (OpenSSL error 336151570)

Relates to golang/go#39568

@HuKeping
Copy link
Contributor

Seems like we should re-generate the fixture certs with SAN first?

Anyway I'll get it.

@stefan-zh
Copy link

stefan-zh commented Apr 19, 2021

What is the status of this pull request? Also, why is the version not bumped in go.mod? https://github.com/thaJeztah/notary/blob/bump_go_version/go.mod#L3

@stefan-zh
Copy link

This pull request has been superseded by #1616 @thaJeztah @justincormack I guess this PR be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants